Use terser-webpack-plugin instead of uglifyjs-webpack-plugin #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some popular, asset heavy libraries, Thanks for this PR. |
|
thanks :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack and create-react-app switched from uglifyjs-webpack-plugin to terser-webpack-plugin. The reason is well written at webpack/webpack#8036 (comment). what do you think about to switch?
refs: https://twitter.com/dan_abramov/status/1060122100340588545
we don't need a workaround as create-react-app does at https://github.com/facebook/create-react-app/blob/5352a0c/packages/react-scripts/config/webpack.config.js#L204-L208 since it's fixed and we use terser version 3.10.12 in this PR.